-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update overlay.js to display actual error message when works with webpack 5.0.0? #2760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update overlay.js to display actual error message when works with webpack 5.0.0? #2760
Conversation
Codecov Report
@@ Coverage Diff @@
## v4 #2760 +/- ##
==========================================
- Coverage 93.77% 93.48% -0.29%
==========================================
Files 34 34
Lines 1333 1336 +3
Branches 381 382 +1
==========================================
- Hits 1250 1249 -1
- Misses 81 85 +4
Partials 2 2
Continue to review full report at Codecov.
|
added null check
Can you provide example the problem? Maybe screenshot(s)? |
Some why "message" object format is changed when I switch from webpack v4.44.2 to v5.0.0. |
Hi, @evilebottnawi Thanks! |
@Xrumet Did you also updated webpack-cli? I had an issue with the dev-server and webpack 5 but I downgraded webpack-cli back to 3.3.12 and it was all fine. |
@phara0hcom No, I am using Node API to start dev server, so I had removed webpack-cli at all. |
@Xrumet Ok, could you try to install webpack-cli |
@phara0hcom sure, I have already tried it right after your previous comment. So, I see "Build failed." message but do not see errors/warnings list. |
Hi @evilebottnawi Seems like that's it for me :( |
@Xrumet Hi, can you rebase? |
For Bugs and Features; did you add new tests?
Motivation / Use-Case
As a user I have updated to Webpack 5.0.0.
Not sure if this fix should be addressed here or in webpack/webpack repo.
Trying to use webpack-dev-server 3.11.0 in order with webpack 5.0.0 and using "overlay" feature I see data format is changed and errors are not displayed in browser's overlay.
This change should avoid the issue and be backward compatible.
Breaking Changes
Additional Info